Skip to content

fix(VE-5851): error handling for getEntryPermissionsCached#434

Merged
hiteshshetty-dev merged 2 commits intodevelop_v3from
VE-5851-no-update-permission-disable-fields
May 13, 2025
Merged

fix(VE-5851): error handling for getEntryPermissionsCached#434
hiteshshetty-dev merged 2 commits intodevelop_v3from
VE-5851-no-update-permission-disable-fields

Conversation

@faraazb
Copy link
Copy Markdown
Contributor

@faraazb faraazb commented May 13, 2025

  • Add error handling for getPermissionsCached usage

Tests failed after adding finally and catch blocks in mouse hover
function
@faraazb faraazb requested a review from a team as a code owner May 13, 2025 11:15
@faraazb faraazb requested review from hiteshshetty-dev and removed request for a team May 13, 2025 11:15
@github-actions
Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 70.83% 8394 / 11850
🔵 Statements 70.83% 8394 / 11850
🔵 Functions 69.21% 290 / 419
🔵 Branches 84.91% 1036 / 1220
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/visualBuilder/listeners/mouseClick.ts 74.53% 80% 90.9% 74.53% 103-104, 107-112, 125-153, 179-180, 225, 283-289, 313-318, 327-333, 351-361
src/visualBuilder/listeners/mouseHover.ts 61.83% 48.64% 58.33% 61.83% 37-44, 77-87, 93-94, 101-104, 107-109, 115, 121-129, 137-139, 141-165, 173-175, 177-179, 187-195, 198-202, 204, 206-208, 223-227, 249-252, 294-297
Generated in workflow #408 for commit 16306dd by the Vitest Coverage Report Action

Copy link
Copy Markdown
Contributor

@hiteshshetty-dev hiteshshetty-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@hiteshshetty-dev hiteshshetty-dev merged commit 166ddc5 into develop_v3 May 13, 2025
10 checks passed
@hiteshshetty-dev hiteshshetty-dev deleted the VE-5851-no-update-permission-disable-fields branch May 13, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants